Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QueryStringForSort #2018

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Oct 27, 2024

  • Migrate Sorts query string into the new approach to match Filters and Search
  • Ensures that configure() is only called once per lifecycle

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (0c8ec45) to head (3659283).
Report is 139 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2018      +/-   ##
=================================================
+ Coverage          87.30%   88.49%   +1.19%     
- Complexity          1672     1891     +219     
=================================================
  Files                150      179      +29     
  Lines               3891     4363     +472     
=================================================
+ Hits                3397     3861     +464     
- Misses               494      502       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 542e797 into rappasoft:development Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant